JakeQZ
JakeQZ
`HtmlPruner::removeRedundantClasses()` takes an allowlist of classes to keep. There should be a corresponding method accepting a list of classes to remove. https://github.com/woocommerce/woocommerce/issues/30551 illustrates how this might be useful.
This is the de-facto standard now for determining 'browser' or email client CSS support for a specific feature. We should probably process these CSS rules as we do `@media` rules...
```sh php "./tools/psalm" -v ``` gives ```text Psalm 4.x-dev@ ``` But if Psalm is installed with Composer by adding the following to `composer.json` ```json "vimeo/psalm": "^4.7.0" ``` then ```sh php...
The method is duplicated in `CssToAttributeConverter` and `CssInliner`. For better maintainability there should be a single common implementation. Perhaps in a trait named `CssDeclarationsParser`, and probably in the `Pelago\Emogrifier\Utilities` namespace....
The method, although simple, is duplicated in `CssToAttributeConverter` and `CssInliner`. For better maintainability there should be a single common implementation. Perhaps in a trait named `XPathQuerier` (we could add other...
During development, we need to be able to run dodgy code, to test it out. This may be a non-issue, because there's no requirement to run the code-checkers, PHPUnit, etc....
See #1138. As and when they can be so can't set milestone.
Just had this thought which is relevant to #668. If we made the methods `protected` instead of `private`, but also marked them as `@internal`, wouldn't that allow those who wanted...
We don't want to be exposed to having to support accidental API leaks (e.g. a class not marked `@internal` that was only intented for internal use, or a method not...
We currently mostly have 2 spaces indentation, e.g. in bulleted lists in `CHANGELOG.md` and `README.md`. But we have 4 spaces indentation specified in `.editorconfig` for `.md` files. We should either...