JakeQZ
JakeQZ
See #646. Due to the way Emogrifier works internally by using `DOMDocument`, any lack of true replication of actual HTML markup when processed through `loadHtml` and then `saveHtml` will be...
These look like genuine errors. It is mysterious that they are not being reported by Psalm on Linux. It is also mysterious that if Psalm is installed via Composer rather...
`preg_replace` and `preg_replace_callback` may return null if an error occurs. A malformed regular expression would be picked up immediately, but [catastrophic backtracking](https://www.regular-expressions.info/catastrophic.html) would depend on the input string. This issue...
This has happened twice now on the weekly CI build: - https://github.com/MyIntervals/emogrifier/actions/runs/3672344362/jobs/6208433701 - https://github.com/MyIntervals/emogrifier/actions/runs/3778793431/jobs/6423554059 In the first instance, re-running the job resulted in successful completion. I have not bothered to...
The first was discovered by another test class more by chance, and (I think) should be tested specfically by `CssInlinerTest`. The second was [reported against Symfony](https://github.com/symfony/symfony/issues/44516). - `[href=https://example.org]` - ~~`#test\:colon`~~
See #1199. The new version of Psalm detects some more type-safety issues that should be resolved (be that with additional annotations, or code changes). Probably several PRs are needed to...
See https://github.com/sabberworm/PHP-CSS-Parser/issues/346. We just need to pass on `CssInliner::$debug` through `Pelago\Emogrifier\Css\CssDocument` to `Sabberworm\CSS\Parser`, mostly with one line of code to be added: ```php $parserSettings = \Sabberworm\CSS\Settings::create()->withLenientParsing(!$debug); ``` This will resolve...
https://github.com/MyIntervals/emogrifier/runs/4501517317 The test run name refers to the last commit, but if I am not mistaken, this is actually a weekly scheduled cron job test run. If possible, the test...
https://github.com/MyIntervals/emogrifier/runs/4501517147 ``` ERROR: UnnecessaryVarAnnotation - src/Css/CssDocument.php:44:18 - The @var Sabberworm\CSS\CSSList\Document annotation for $sabberwormCssDocument is unnecessary (see https://psalm.dev/212) /** @var SabberwormCssDocument $sabberwormCssDocument */ ERROR: ArgumentTypeCoercion - src/Css/CssDocument.php:98:39 - Argument 1 of...
E.g. https://github.com/MyIntervals/emogrifier/runs/4501517317 ``` There were 2 failures: 1) Pelago\Emogrifier\Tests\Unit\Css\CssDocumentTest::parsesSelector with data set "attribute (value match)" ('[href=https://example.org]') Failed asserting that actual size 0 matches expected size 1. /home/runner/work/emogrifier/emogrifier/tests/Unit/Css/CssDocumentTest.php:40 2) Pelago\Emogrifer\Tests\Unit\CssInlinerTest::inlineCssInDebugModeForInvalidCssSelectorThrowsException Failed...