emogrifier icon indicating copy to clipboard operation
emogrifier copied to clipboard

Published 20 hours ago • verified publisher icon MyIntervals

Move the CSS parsing into a class/trait

Open oliverklee opened this issue 5 years ago • 5 comments

oliverklee avatar Sep 28 '19 16:09 oliverklee

We currently have methods parseCssDeclarationsBlock and getAllNodesWithStyleAttribute that are duplicated in CssInliner and CssToAttributeConverter, that could be moved to shared traits. That is an overlapping issue, but not the same as moving all CSS parsing to a class.

JakeQZ avatar Sep 28 '19 17:09 JakeQZ

Doesn't #544 already cover this (apart from the issues I mentioned in my previous comment here)?

JakeQZ avatar Sep 28 '19 20:09 JakeQZ

This issue is about a potential solution for #734. I'm not quite sure whether we should move the CSS parsing into a separate class/trait, use some 3rd-party library, or both.

oliverklee avatar Sep 28 '19 21:09 oliverklee

But isn't this issue, #734, a duplicate of #544?

JakeQZ avatar Sep 28 '19 21:09 JakeQZ

I've added #738 and #739 for the side issues I mentioned.

JakeQZ avatar Sep 29 '19 00:09 JakeQZ