Lukas Tenbrink

Results 234 comments of Lukas Tenbrink

Since Jolt has been merged by now, it may be interesting to benchmark it with an SSE4.2 build (vs baseline master). They mention both SSE4.1 and SSE4.2 support [on GitHub](https://github.com/jrouwe/JoltPhysics).

Unfortunately, git does not have a concept of a rename. I have not touched any code in `linked_list.h`, except for renaming it, but the code change appears big because `list.h`...

> Regarding how to introduce the change, I'm a bit worried this may break compatibility with modules or GDExtensions. I _think_ it won't cause issues the way i have it,...

> I think this would really only be appropriate if we actually had a List that is maybe more like a Python list or something explicitly, but we have LocalVector...

Alright, i confess this PR is just too forward, especially with the concerns and other arguments that have been brought up. If there's still interest in the change, a proposal...

> many functions show two zones in the profiler, an 'outer' and an 'inner'. Ideally these would be one zone, but this isn't a blocker for this PR in my...

This is a problem in the shutdown sequence. `godot_cleanup_profiler` should be called just before `StringName::cleanup` is called. So this is a platforms issue (no such messages are printed on macOS).

Ohh, sorry, I mistook the PR at the top. I expected from the title it would be related to the profiler. > It happens on Linux as well so it's...

MSVC is failing due to the `feed_effects` bug again (3rd PR where this happens). To quote myself from last time: > To avoid the MSVC compiler issue (which I have...

> > MSVC is failing due to the feed_effects bug again (3rd PR where this happens). To quote myself from last time > > Is it failing locally on a...