Lukas Tenbrink

Results 234 comments of Lukas Tenbrink

Not sure why the windows builds are failing. I don't have this problem with any of my git runners. If this is related to the PR, we can default to...

Right, i forgot to change the final commit message after the changes. Should be good now!

If I understand it correctly, the handled failure case here would be a developer error. I would argue instead of silently failing, we should check for argument congruity before the...

I think many people use external tow for this. But depending on how difficult it is to implement i could see a basic version of this be in the Godot...

Forgot that I also needed version.py. i added that bit in.

I needed to say goodbye to lvalue references. Besides the rather explicit crashes on conversions, the explicit lvalue conversions were being used automatically leading to unit test crashes already. Pointers...

Ok, I refactored to use `variant.get_xxx` notation instead. This is closer to `std::get(variant)` syntax, with the main difference being that we return a pointer rather than an lvalue reference, which...

> These functions seem basically the same as the `VariantInternal::get_*()` functions. Oh, I had no idea those existed! There remains a small difference in that my implementation checks for variant...

Superseded by #99201 because Variant internal has the proposed functionality already, an equivalent just needs to be exposed to gdextension.

No, you're right, it does make sense to have a `StringName` constructor considering that `NodePath` using `StringName` path elements. I think I made the comment assuming that `String` path elements...