Nick Barry

Results 65 comments of Nick Barry

A `favicon.png` is generated, regardless of whether the `-d` option is used.

The `.png` generation seems to work as expected, but no `.ico` is generated at all. However, it works when I specify the `--minimum` option. It's not entirely clear what this...

That seems unnecessary, as all of the contracts are in the root directory of the package. Example: https://github.com/Premian-Labs/premia-contracts/blob/aabd867b39c5efbb5cf668115bc4c99581ce6145/contracts/pool/PoolWrite.sol#L6

Try this: https://github.com/davidmerfield/randomColor/

The Plotly library appears to generate the graph using random colors by default, but they're highly saturated and Covid Trends overrides them to gray. I can't tell whether Plotly has...

It should go in `lib`. It's blocked by the fact that `lib` is disorganized and lowest priority.

Include a `FacetCut` TS interface.

https://eips.ethereum.org/EIPS/eip-2771

Thanks for the PR, I'll review soon. Not much time at the moment.

This is required for PR #139, meaning that the breaking change mentioned in comments above is probably worth it. Merging into the `error-types` branch.