Nick Barry

Results 65 comments of Nick Barry

Once again, I apologize for the delay. I've made some changes, and I believe this is almost ready to merge. One outstanding question: why shouldn't `grantRole` revert if a user...

Yeah, the PR matches the original OZ implementation, but the same question could also be asked there. `AccessControl` isn't based on an EIP, so it's okay to make improvements. Thought...

Implemented option 3.

Should use `vaults` branch as base branch due to addition of `ERC20BaseInternal#_allowance` function. Edit: `vaults` branch has been merged in to `master`.

While in the majority of cases the gas savings would be desirable, I think the potential for unexpected behavior outweighs the benefit. For reference, the Solmate ERC20 implementation includes this...

I will try to prioritize this a bit more, though it will still take some time. Would accept a PR in the meantime.

Implemented in #95 and released in version `0.0.42`. Thanks @iam-dev.

Also related: #34, #69.

Okay, let's repeat that pattern then. Best to branch off of `data-structures` branch for each new data structure (for now).

Singular `interface/` directory is not compatible with typechain.