Nick Barry
Nick Barry
It might be better to replace the error with a warning.
Should name it something like `ERC721RoyaltyData` and add to `contracts/token/ERC721/royalty_data/`. `ERC721Royalty` is more concise, but incorrectly implies that royalties are enforced.
1. Can you think of a good place to put it other than `ERC721/royalties/` and `ERC1155/royalties/`? 2. Gas inefficiency is okay if we provide a way for the developer to...
For now, put it in `contracts/token/common/ERC2981/`. Might update that during review.
Partially completed in #144.
Need confirmation that the improved hashing function will not cause issues for end-users who might be working with data in memory. Otherwise, I think this is complete.
I updated so that the tree accepts hashes directly, rather than raw data. The end user must do the hashing. This increases efficiency if: 1. The data the user is...
@NouDaimon I'm merging this now. We can merge the optimizations later, after further review or audit. Thanks @hinterlist.
Actually, I'm going to merge now so that the `data-structures` branches can be consolidated and published. Comment if you have issues with the test updates.
> I have a contract A with some internal functions, and then contract B inherits A and calls the internal functions. In this case, the size of those internal functions...