David Richards, Jr.

icon indicating an email [email protected]

icon company @Comcast icon location User Experience Engineer at Comcast working on component libraries and entertainment prototypes.

Results 4 comments of David Richards, Jr.

fix(NavigationManager): allow itemPosX and itemPosY to animate

> ![alignment-issue](https://private-user-images.githubusercontent.com/2578683/312515146-e1e67ad9-30ae-48a2-870e-059a82a43ed3.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzNjI0OTgsIm5iZiI6MTcxMDM2MjE5OCwicGF0aCI6Ii8yNTc4NjgzLzMxMjUxNTE0Ni1lMWU2N2FkOS0zMGFlLTQ4YTItODcwZS0wNTlhODJhNDNlZDMuZ2lmP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMjAzNjM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjE5MGIyNWIzNWU0OTU4YWNmN2ViNDhmMmU2N2FjNzUzZTg0NjZkN2U0NGQwNzk2OGE0NDE0MDA4ZmU3OWU1ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UDRjY7oQQgAdkPYb-YDMjlKxUekxl_chpdIoh7maY6Y) [ ![alignment-issue](https://private-user-images.githubusercontent.com/2578683/312515146-e1e67ad9-30ae-48a2-870e-059a82a43ed3.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzNjI0OTgsIm5iZiI6MTcxMDM2MjE5OCwicGF0aCI6Ii8yNTc4NjgzLzMxMjUxNTE0Ni1lMWU2N2FkOS0zMGFlLTQ4YTItODcwZS0wNTlhODJhNDNlZDMuZ2lmP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMjAzNjM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjE5MGIyNWIzNWU0OTU4YWNmN2ViNDhmMmU2N2FjNzUzZTg0NjZkN2U0NGQwNzk2OGE0NDE0MDA4ZmU3OWU1ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UDRjY7oQQgAdkPYb-YDMjlKxUekxl_chpdIoh7maY6Y) ](https://private-user-images.githubusercontent.com/2578683/312515146-e1e67ad9-30ae-48a2-870e-059a82a43ed3.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzNjI0OTgsIm5iZiI6MTcxMDM2MjE5OCwicGF0aCI6Ii8yNTc4NjgzLzMxMjUxNTE0Ni1lMWU2N2FkOS0zMGFlLTQ4YTItODcwZS0wNTlhODJhNDNlZDMuZ2lmP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMjAzNjM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjE5MGIyNWIzNWU0OTU4YWNmN2ViNDhmMmU2N2FjNzUzZTg0NjZkN2U0NGQwNzk2OGE0NDE0MDA4ZmU3OWU1ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UDRjY7oQQgAdkPYb-YDMjlKxUekxl_chpdIoh7maY6Y) [ ](https://private-user-images.githubusercontent.com/2578683/312515146-e1e67ad9-30ae-48a2-870e-059a82a43ed3.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAzNjI0OTgsIm5iZiI6MTcxMDM2MjE5OCwicGF0aCI6Ii8yNTc4NjgzLzMxMjUxNTE0Ni1lMWU2N2FkOS0zMGFlLTQ4YTItODcwZS0wNTlhODJhNDNlZDMuZ2lmP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTNUMjAzNjM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjE5MGIyNWIzNWU0OTU4YWNmN2ViNDhmMmU2N2FjNzUzZTg0NjZkN2U0NGQwNzk2OGE0NDE0MDA4ZmU3OWU1ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UDRjY7oQQgAdkPYb-YDMjlKxUekxl_chpdIoh7maY6Y) This looks fantastic on the whole. I am however hitting this case around the 6th Row I'm able to replicate this on any...

fix(FocusManager): add style TS definitions for FocusManager, NavigationManager, Row, and Column

To add a comment instead of just approving: I agree with this approach and think that it makes sense to define styles at each level, even if they are exactly...

fix(ListItemSlider): min and max value coordinate to correct set values

Adding a `min` and `max` property to ListItemSlider and then patching it into the Slider feels like a weird approach to me. Those two properties should already be defined when...

fix(Colors): enable [token, newAlpha] format

@erautenberg Regarding [this change](https://github.com/rdkcentral/Lightning-UI-Components/pull/499/files#diff-63ccff1d65ce2d205ca47322f676f9890010560e78ce4ae5a7f9894475e21acbR392-R394) from #499 and whether it should be adjusted in this PR, I just want to make sure that you agree that we should only be allowing...