rdkcentral
fix(ListItemSlider): min and max value coordinate to correct set values
Description
The min and max value on the ListItemSlider weren't preserving the user input values on refresh. This was caused by generating the Slider story as a substory in the ListItemSlider story. The values being set were being reset from the Slider's default setting. Moving the min and max values into the ListItemSlider's story resolves the issue and preserves the values.
References
Testing
Automation
Checklist
- [x] all commented code has been removed
- [x] any new console issues have been resolved
- [x] code linter and formatter has been run
- [x] test coverage meets repo requirements
- [x] PR name matches the expected semantic-commit syntax
Adding a min and max property to ListItemSlider and then patching it into the Slider feels like a weird approach to me. Those two properties should already be defined when the user passes in the slider property, so this feels redundant.
I was able to resolve the issue on develop by just adding this._Slider._update(); after line 127 in ListItemSlider.js. It seems like even though we are patching in properties to the Slider component that should trigger an update, the update isn't running. If you force it to, it maintains any story values you've changed when you refresh the page.
:tada: This PR is included in version @lightningjs/ui-components-v2.21.6 :tada:
The release is available on:
Your semantic-release bot :package::rocket: