rdkcentral
fix(NavigationManager): allow itemPosX and itemPosY to animate
Description
The itemPosX and itemPosY properties of FocusManager/NavigationManager/Column/Row instantly updated the x and y values of the Items element. This prevents animating the Items element and making a smoother transition for something like the Title and Items in the TitleRow if the titleMarginBottom changes on focus/unfocus. The scrolling logic will update the Items container's x or y based on the scroll direction, so this just updates the opposite direction for something like the title.
References
Testing
Check out the new "Shifting Item Pos" story for the Column container and confirm that the titles are shifting as expected while the scrolling logic is also still behaving as expected.
Automation
Checklist
- [ ] all commented code has been removed
- [ ] any new console issues have been resolved
- [ ] code linter and formatter has been run
- [ ] test coverage meets repo requirements
- [ ] PR name matches the expected semantic-commit syntax
This looks fantastic on the whole. I am however hitting this case around the 6th Row
I'm able to replicate this on any row with buttons 6 through 10, and button 5 if you navigate to it from button 6. Having any of those buttons selected, leaving the row, and then coming back to it, that selected row sits on top of the title of the row below.
