Peter Hall

> trust the user to check statuses On the whole its better to not trust the user ;). The key thing is that the pre-arm check makes a text report...

> I'd expect that GPS_TYPE2 = 21 (ExternalAHRS) shouldn't be set when using a single GNSS system. That could be a valid setup if you have a normal GPS first....

> What do you think is necessary before merging this branch? More generally, should you be the one to review these PR's (I have a few more coming) or is...

> @IamPete1 @tridge > > It looks like there is a unit test failure that, as far as I can tell, is totally unrelated to my changes. How should I...

> Looks like the CI passed. Should I expect this to automerge in or is some other intervention necessary? It will have to be merged manually. I see you pushed...

> @IamPete1 Sorry mate, I didn't understand what you were asking. The `ATSC` message contains the used values of the angle P scale and the rate PD scale if not...

> > How can I run these checks myself? This should work: ``` apt install lua-check ./Tools/scripts/run_luacheck.sh ``` You can also run the new checks with: ``` python ./Tools/scripts/run_lua_language_check.py ```

Yep, its not allowed https://github.com/ArduPilot/ardupilot/blob/659286ee4fe3895e164e2110f23be715e60e941c/ArduPlane/quadplane.cpp#L3230-L3232 The question is should we allow it or update the wiki?

If scripting has to set it in anycase why not use scripting for the whole thing? You can receive and send MAVLink messages from Lua.

Also the `AP_CAMERA_INFO_FROM_SCRIPT_ENABLED` `AP_MAVLINK_MSG_VIDEO_STREAM_INFORMATION_ENABLED` might need to be in the scripting bindings too? You can do a depends on methods too if you want the main scripting support.