Filipp Riabchun

Results 75 comments of Filipp Riabchun

I encounter exactly this when trying to follow https://gist.github.com/shilman/8856ea1786dcd247139b47b270912324 Reproduction: https://github.com/JetBrains/ring-ui/tree/webpack-5 ```sh npm install npm run bootstrap npm run build ```

@shilman I see. I think I'll just extract custom-header into a separate lerna package with its own dependencies

@shilman for some reason, my setup broke after updating preview to `[email protected]` https://github.com/JetBrains/ring-ui/tree/dependabot/npm_and_yarn%2Fwebpack-5.32.0 `npm install && npm run bootstrap && npm run build` ``` info @storybook/html v6.2.7 info info =>...

In `WindowScroller`, it can be avoided by using [`registerChild` render prop](https://github.com/bvaughn/react-virtualized/blob/master/docs/WindowScroller.md#render-props) I'm going to open a PR adding the same pattern for `CellMeasurer` UPD: #1477

Even if I use `registerChild`, `WindowScroller` doesn't seem to work with `StrictMode`: https://codesandbox.io/s/react-virtualized-list-with-width-100-dunc2 You can see that if you scroll list down, new items don't appear. This can mean that...

Please add a test case for `` with multiple children. Looks like current approach doesn't cover it properly ``` ```

> Most of the hook-related things are in the react 16 adapter. Which doesn't seem to have a changelog at all =( https://github.com/airbnb/enzyme/tree/master/packages/enzyme-adapter-react-16

@DudaGod Вот пример обновления, которое достаточно просто смёрджить: https://github.com/gemini-testing/q-promise-utils/pull/4. Из лоудеша там используется [`_.find`](https://github.com/gemini-testing/q-promise-utils/blob/bb1ab448702d181e0ee5420c0c0c201c89a24a92/lib/utils.js#L26), в котором не было брейкинг ченджей в 4.0: https://github.com/lodash/lodash/wiki/Changelog#v400

Looks like this wd library is abandoned by maintainers. There is an open PR fixing that with no reaction for half a year https://github.com/admc/wd/pull/494 @sipayRT How do you feel about...