Filipp Riabchun

Results 75 comments of Filipp Riabchun

@marekfeikus I'm not, so feel free to

> `React$ElementProps` nor `React$ElementProps` does not bring all the same validation. Oh I see. Looks like Flow doesn't validate DOM props at all: https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVBLAtgBzgJwBdkwBDAZzACUBTUgY2KnzizAHJ87H31hgwAEgCiADxw1Gw-C3wAuMAAsuUMOUVwArjAAmYAEY01hfBgB2Ac1QAeUkpUBeAN4BGAEwBmAL5hgAPlQgA It should probably be fixed with...

I have built dist with this change in my own fork and can confirm that it fixes the issue on Quest 2 Live example: https://glitch.com/edit/#!/enormous-fire-shop

Can you please also support `@raw_response_type` directive?

I've added one more point: "use sinon fake timers instead of `setTimeout`". To do that, we also need to use some stub for `requestAnimationFrame` like [this one](https://github.com/alexreardon/raf-stub), or write one...

>The false-positives thing has been very tricky in my experience - Working locally, the timing is very accurate, but on CI the timing is far less predictable. An animation set...

What do you guys think about wrapping every child in a div (or an optional user-provided tag) inside FlipMove's render, as Dan Abramov [suggests](https://github.com/yannickcr/eslint-plugin-react/issues/678#issuecomment-232293175) for a similar case of HOCs?...

>we'd be wrapping all of the children I think it's actually an expected behaviour, as long as we don't embrace #148's approch and keep using react children as animated entities....

>The big caveat is that it would cause even more problems for people when the markup is important (grids, flexbox, tables, etc) For such cases, if just redefining the wrapper's...

> Unless we could work backwards from the DOM node to find the React element? There is a way, but it's not a public API and may change at any...