Thomas Casteleyn comments

Results 466 comments of


                                            Thomas Casteleyn

feat(outputs.opensearch): opensearch output plugin

Can you mark the PR as draft in the meantime please?

feat(inputs.vsphere): Adding vSAN extension to vSphere plugin

@gangadharaswamy Can you please alaborate? Either the documentation is wrong, or the sample config is wrong IMHO.

feat(outputs.opensearch): opensearch output plugin

Hmm, okay, I think we should wait for @srebhan to come back on https://github.com/influxdata/telegraf/issues/13034#issuecomment-1507280841 first before going more into detail..

feat(inputs.vsphere): Adding vSAN extension to vSphere plugin

There is a bugfix release every 3 weeks and a quarterly feature releas. Since this is not a bug fix , but a feature, it will be on the next...

feat(outputs.opensearch): opensearch output plugin

To see which approach would be taken, in order to avoid the need to rework stuff again afterwards.. But I agree @mannukalra could already start implementing..

fix(agent): only set default snmp after reading all configs

What if the first loaded file has it set? Will you get the warning for each file after?

Auto create table in BigQuery

If my customer wants this feature, I will try to create a PR for it.

inputs.sflow: Parse extended packet format (type 1001)

Why? I was going to look into rewriting the `inputs.sflow` plugin to use the module I mentioned. If `inputs.sflow` is considered to be deprecated and `inputs.netflow` should be used, then...

inputs.sflow: Parse extended packet format (type 1001)

Wait, now you are saying the Netflow plugin also doesn’t fit? (As that is currently using goflow2)

inputs.sflow: Parse extended packet format (type 1001)

Yes, see [DecodeFlowRecord](https://github.com/netsampler/goflow2/blob/v1.3.6/decoders/sflow/sflow.go#L168-L305), which can handle these specific cases. But I don't see why you want to deprecate the sflow specific plugin? NetFlow and sFlow are not the same, but...