feat(inputs.vsphere): Adding vSAN extension to vSphere plugin

[gangadharaswamy]

Required for all PRs

• [x] Updated associated README.md.
• [x] Wrote appropriate unit tests.
• [x] Pull request title or commits are in conventional commit format

resolves #5966

This resumes the old PR #5970.

[gangadharaswamy]

@srebhan Could you please review this PR?

[yogeshprasad]

@srebhan can you please have a look into this as @gangadharaswamy has fixed the review comments?

[srebhan]

@gangadharaswamy can please run make docs and fix the CI/build errors!?

[powersj]

Hi @gangadharaswamy,

For the tests, you need to add the new package to the list of our dependencies:

diff --git a/docs/LICENSE_OF_DEPENDENCIES.md b/docs/LICENSE_OF_DEPENDENCIES.md
index 030430695..2a5d22095 100644
--- a/docs/LICENSE_OF_DEPENDENCIES.md
+++ b/docs/LICENSE_OF_DEPENDENCIES.md
@@ -78,6 +78,7 @@ following works:
 - github.com/awslabs/kinesis-aggregation/go [Apache License 2.0](https://github.com/awslabs/kinesis-aggregation/blob/master/LICENSE.txt)
 - github.com/benbjohnson/clock [MIT License](https://github.com/benbjohnson/clock/blob/master/LICENSE)
 - github.com/beorn7/perks [MIT License](https://github.com/beorn7/perks/blob/master/LICENSE)
+- github.com/blang/semver [MIT License](https://github.com/blang/semver/blob/master/LICENSE)
 - github.com/blues/jsonata-go [MIT License](https://github.com/blues/jsonata-go/blob/main/LICENSE)
 - github.com/bmatcuk/doublestar [MIT License](https://github.com/bmatcuk/doublestar/blob/master/LICENSE)
 - github.com/caio/go-tdigest [MIT License](https://github.com/caio/go-tdigest/blob/master/LICENSE)

Additionally it looks like you have a failing lint result, as the queryPerformance function is always returning nil:

  Error: (*Endpoint).queryPerformance - result 0 (error) is always nil (unparam)

Thanks!

[srebhan]

Or even better use: github.com/coreos/go-semver...

[powersj]

Hi @gangadharaswamy,

Looks like your latest push is failing the tests. Could you look at fixing those up?

Thanks!

[gangadharaswamy]

@powersj Thank you! Will look into the issues.

[Hipska]

@gangadharaswamy Can you please alaborate? Either the documentation is wrong, or the sample config is wrong IMHO.

[gangadharaswamy]

The vsan_metric_include = [] or vsan_metric_include = [<list_of_metrics>] and vsan_metric_exclude = [ ] commented or uncommented collects vSAN metrics. vsan_metric_exclude = [ "*" ] excludes all vSAN metrics.

[telegraf-tiger[bot]]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.

:relaxed: This pull request doesn't significantly change the Telegraf binary size (less than 1%)

:package: Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[gangadharaswamy]

@srebhan Could you please review the PR?

[gangadharaswamy]

@srebhan What's the next step? Is there anything that needs to be done to move forward?

[powersj]

@srebhan What's the next step? Is there anything that needs to be done to move forward?

Sven and I just went through all the outstanding PRs to see what we need to do. For this PR he needs to get you a review. nothing needed from your side.

[gangadharaswamy]

Hi @srebhan , @powersj, To which Telegraf release this PR will be considered? Will it be part of alternative weekly releases or quarterly releases?

[Hipska]

There is a bugfix release every 3 weeks and a quarterly feature releas. Since this is not a bug fix , but a feature, it will be on the next feature release, which is planned at June 12th.