Thomas Casteleyn

Results 466 comments of Thomas Casteleyn

> I already did in my original review. Okay, I added some extra comments to the mentioned method and others as well. I hope this makes it more clear. >...

Can someone give feedback to my 2 concerns here please: https://github.com/influxdata/telegraf/pull/14223#issuecomment-1851842807

Anyone please? I would really would like to get this landed before next release, but if I don't get responses weeks later, I'm afraid we will mis the next one...

Yeah, looks like this is a good direction. I think you will need to create a PR at our fork in order to get it added to this branch. I...

@powersj @srebhan any update? I would rather not miss the next feature release.

@srebhan @powersj I think this is ready for a final review. I have it now running fine on DEV with 5 instances of the plugin.

@srebhan @powersj Please, there's only 2 weeks left for next feature release.