Thomas Casteleyn

Results 466 comments of Thomas Casteleyn

> @Hipska did you even look at the [netflow input plugin](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/netflow)? It uses the `github.com/netsampler/goflow2` library which supports netflow v5, v9, IPFIX and sflow v5... Yes, see this specific line...

You need to look at the correct version of the source code, this is `snmp.go:323`: https://github.com/influxdata/telegraf/blob/v1.29.5/plugins/inputs/snmp/snmp.go#L323 Going though the stack trace, the panic actually happens here: https://github.com/sleepinggenius2/gosmi/blob/v0.4.4/models/format_bits.go#L31 Which should be...

I would try to get that fixed upstream and see what the maintainers say.

It appears like the maintainer didn't do much anymore lately. Let's see indeed.

@powersj Conversation continued in https://influxcommunity.slack.com/archives/CH99HUH8V/p1713516740749229

Indeed, that's why I instructed @ManuelPrandini to create a Feature Request for this.

Hmm, I think it makes more sense to have an extra option to enable the full file name in the existing tag. Current: ``` metric,file=telegraf.log msg="foobar" ``` New: ``` metric,file=/var/log/telegraf.log...

> 1. Can we please also move the netsnmp implementation to the common dir! It can, however I thought we agreed that new plugins only should use the gosmi implementation,...

Moving all of internal/snmp to plugins/common/snmp involves too much stuff unrelated to the initial task and as stated, a lot of this code hasn't good test coverage. So too much...