Helge Stenström

Results 60 comments of Helge Stenström

The demo applications are outside the scope of this pull request, I think.

Yes, please be more specific. I'm interested to learn about the scenario where multiple threads are calling the same player. What is the use case? How would it be helped...

I don’t think it looks like the same solution. Compare their play method to yours. They have most of it guarded by a thread lock, you have not. (I’m browsing...

I need to correct myself. Their notifyEvent really does create a thread. But they don’t wait for its termination or for it to return a result. I don’t understand their...

I haven't tested with flac, but I might have some file on my drive. But the question was: How does it happen? In other words: Where is the implementation of...

I saw that in the pom file, but I don't see where the jflac-codec is actually used. Maybe I didn't find it because the package name is different from the...

Yes, I'm using Java 8 myself at work, so now is probably not the right time to do the change. It would be wonderful if Java9 modules could be provided...

Rebased, to remove merge conflict.

See for yourself. Current master branch, line 657: https://github.com/goxr3plus/java-stream-player/blob/e50245f11518a91309ccefbcdc2a7d977a21b529/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L657 But there is no place where future is assigned a value. The default value set on line 145 is null. https://github.com/goxr3plus/java-stream-player/blob/e50245f11518a91309ccefbcdc2a7d977a21b529/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L145...