Helge Stenström
Helge Stenström
Rather than line 1-781, I would focus on lines 603-656, the part between lock and unlock. But it depends on what you mean by "better performance". Have you measured the...
https://github.com/goxr3plus/XtremeMediaPlayer/blob/73fe33598dae59e04dac68610d84851490d5b4a4/src/xtrememp/player/audio/AudioPlayer.java#L628 It looks nice to have a method with only one parameter here. But I don't think it improves performance.
So leave XR3Player out when you compare performance of locking methods.
This looks interesting: https://plumbr.io/blog/locked-threads/improving-lock-performance-in-java
This is more of a bug report than a real pull request. The PR has one test, and the test doesn't end quickly as tests should, so it's useless as...
No, that wasn't the intention. It's more of documentation for the bug report.
No, you have to do a conversion between linear scale and logarithmic (dB) scale. Since the setter method name and the getter method name don't match, there is an opportunity...
But that is not the way it works now, since the future is not returned from submit. It's not even created, as far as I can see. It's null, and...
Have you read https://wiki.sei.cmu.edu/confluence/display/java/CON50-J.+Do+not+assume+that+declaring+a+reference+volatile+guarantees+safe+publication+of+the+members+of+the+referenced+object You might have multithreading issues already.
Issues #1 and #15 might be regarded as multithreading issues, I think.