Helge Stenström

Update ExtensionTool.java

3

getFileExtension() doesn't return null, so we don't have to check for it.

module java.base does not open java.lang.reflect to module XR3Player

7

When I start XR3Player (current master branch), I get the following written to the console, including error messages. I'm running in IntelliJ IDEA Community 2019.2. Entered JavaFX Application Start Method...

VisualizerType simplifications

9

The enum VisualizerType has been simplified by removing the string representation, and replacing it with an integer representation. Currently, the only usage that I have seen for the integer representation,...

Update MediaTableViewer.java

3

key.isControlDown() is always true at this point. Replace with true.

Tell me about how you use your own separate libraries in this project

3

I'm curious to how you work with changes in java-stream-player that you do for the needs of XR3Player. Do you use java-stream-player as a compiled jar-file when you run XR3Player?...

https://github.com/goxr3plus/XR3Player/blob/b222ce496f47b1ffc121e768b4f3f24999906213/src/main/java/com/goxr3plus/xr3player/services/chromium/ChromiumUpdaterService.java#L9 This package com.goxr3plus.xr3player.services.chromium is not about playing streams, and com.goxr3plus.streamplayer.stream has nothing to do with what a web browser needs. I think this dependency should be removed. One way...

Isn't there a better way to exit the application, than to call System.exit()?

1

https://github.com/goxr3plus/XR3Player/blob/b222ce496f47b1ffc121e768b4f3f24999906213/src/main/java/com/goxr3plus/xr3player/application/MainExit.java#L96 Calling System.exit() is a pretty brutal way of exiting. Most programs don't need that. Since this is a multithreaded program, you need to stop the execution of these threads....

Nothing should depend on Main.

5

In the book Clean Architecture by Robert C Martin, the author recommends that nothing should depend on Main. The purpose of Main should simply be to start the application. There...

Tabs or spaces?

2

Do you want the code indented by tabs or spaces? Personally, I prefer spaces.

Unused media players?

7

https://github.com/goxr3plus/XR3Player/blob/56cfe5cc09edf666055f5ebe8a25ff1038f85600/src/main/java/com/goxr3plus/xr3player/controllers/general/WelcomeScreen.java#L55-L56 What's the purpose of the two media players? Are they leftovers from old solutions? It seams that you are not using JavaFx for the audio. What are you using...