Helge Stenström

Results 60 comments of Helge Stenström

I didn’t run it. Your problem above looks like a compile time problem, and I doubt that it’s caused by my changes. At least not by one particular change, but...

I have made a branch where Oscilloscope and its siblings can now be instantiated independently of each other. They are no longer owned by VisusalizerDrawer, but by a new class...

I fooled myself: my refactoring did not remove the cross-dependence between VisualizerDrawer and the "gadgets". I just moved the point where these items are created. I have to think a...

Again I have to correct myself. The refactoring did help. That is because the creation of Oscilloscope and siblings are done at creation of Visualizer, but Oscilloscope only needs a...

If I understand correctly, once the player is started, we have 5 instances of Oscilloscope, 5 instances of JuliaSet, and so on. How many of these may at most be...

Some books that have helped me, and which have inspired my proposed changes: https://www.goodreads.com/book/show/3735293-clean-code https://www.goodreads.com/book/show/18043011-clean-architecture https://www.goodreads.com/book/show/37646821-effective-java

My changes were a step in the wrong direction. All fields that were moved are static, and represent global state. It’s still global state after the move. Instead the fields...

The two main problems I see in Main are connected. Nothing should depend on Main (according to the book Clean Architecture). Global state is bad (according to many books and...

No, I haven't tested it, I have just studied the code. IntelliJ says that extension != null is always true. extension is never null, because IOInfo.getFileExtension(fileName) never returns null. IOInfo.getFileExtension(fileName)...

I guess my question is related to https://github.com/goxr3plus/java-stream-player/issues/15