HaRoLd

Have done some research into this. With `2*ceil(log2(p))` versus `n*...` where `n>2` you get diminishing returns on how uniform the distribution is. Say if the prime is `b` bits, and...

The approach used by `libff` is to clear all bits higher than the MSB of modulus, then reject samples until it's within the field. This has a potentially unlimited bound,...

I've added three automated code quality checkers: * https://app.codacy.com/project/HarryR/ethsnarks/dashboard * https://bettercodehub.com/results/HarryR/ethsnarks * https://www.codefactor.io/repository/github/harryr/ethsnarks

Hi @drewstone I'm not following any specific C++ style, but I've reviewed some of the guidelines and I'm slowly making progress. I've been trying to make the C++ easier to...

Hi @jcastle13 I've made some improvements on this branch: https://github.com/HarryR/ethsnarks/tree/cxx-cleanups-plus-merkle Any insight into how to make it more difficult to introduce bugs or make accidental mistakes, make it easier for...

@jcastle13 sorry, I merged that branch into master. See: https://github.com/HarryR/ethsnarks

Awesome, thanks for spending the time to help. Are there any projects you've come across with very clean C++ programming practices, that would be good to use for positive influence...

No problem @jcastle13 - that's just an automated message from gitco.in (I have no control over it). At the end of the day this is all about learning how to...

Ya you can clone `master`, feel free to make big breaking changes as long as the automated builds pass and we slowly improve the tests, there are also a handful...

Hi @aman935 and @upendra2412 Have you any suggestions about improving code quality?