Hans Olsson

Results 628 comments of Hans Olsson

@MartinOtter @sjoelund this PR has been stuck for about 2 months.

> I would prefer one of the following options: > > 1. Make `SweptVolume` extend `Modelica.Mechanics.Translational.Interfaces.PartialCompliant`, which would make it similar to a spring or damper with two ends that...

> I have found an issue with `Modelica.Media.Examples.SolveOneNonlinearEquation.Inverse_sine`. It contains a call to `Modelica.Utilities.Streams.print` directly in the equation section. Since `print` is an impure function this is not allowed. Note...

> > Note that there is an exception for `print` so it is deprecated behavior without any required diagnostics. > > Is that how it is supposed to be interpreted?...

> What is the string length of UTF-8 strings? Is it the number of characters or the number of UTF-8 code points? There are more choices https://www.unicode.org/faq/char_combmark.html#17 indicate that another...

> UTF-8 is the most used encoding scheme -- it basically is _the_ standard; other encodings are close to become negligible (cf. for example https://w3techs.com/technologies/details/en-utf8). And to clarify: after UTF-8...

That isn't clear, and Unicode-strings are already sneaking into models - since models depend on external resources and those external resources may be in directories with Unicode-characters. That is important...

> @henrikt-ma Hmmm ... tried your solution with Dymola 2021x: Function input had incorrect type in the definition equation result = size(b, 1) > 0 and min(b) Argument number 1...

For TwoPort and FourPort I believe the gradients were a plain mistake, and removed them.

> I'm not really sure what this is all about, am I supposed to know? Perhaps, the change in Modelica.Fluid.Vessels should**n't** change the diagrams seen in Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWith3InletOutletArraysWithEvaporatorCondensor Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWithTopPorts for Dymola;...