ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Almost automatically updated to have correct gradient.

Open HansOlsson opened this issue 3 years ago • 5 comments

Primarily done using a new flag of updateModelicaAnnotations in Dymola. But Modelica/Electrical/Machines/Icons/(Quasi|)StaticTransformer.mo was also manually converted to be more line-based texts (makes future changes more logical), and some part of Modelica.Electrical are missing here - need to investigate. Closes #3951

HansOlsson avatar Feb 18 '22 10:02 HansOlsson

For TwoPort and FourPort I believe the gradients were a plain mistake, and removed them.

HansOlsson avatar Feb 18 '22 13:02 HansOlsson

I'm not really sure what this is all about, am I supposed to know?

casella avatar Feb 19 '22 00:02 casella

I'm not really sure what this is all about, am I supposed to know?

Perhaps, the change in Modelica.Fluid.Vessels shouldn't change the diagrams seen in Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWith3InletOutletArraysWithEvaporatorCondensor Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWithTopPorts for Dymola; and possibly make it look better in other tools.

HansOlsson avatar Feb 20 '22 19:02 HansOlsson

To clarify for @casella @christiankral it is intended to solve the #3951 that found that

Some classes have Icon annotations where there is a fillPattern which should give a gradient, but they have lineColor explicitly equal to fillColor which results in a solid fill instead.

In Dymola such classes are rendered as if lineColor is black which gives a good visual gradient, and this PR just changes to use black lineColor instead (except some that shouldn't have gradient).

HansOlsson avatar Mar 08 '22 18:03 HansOlsson

If you use Dymola and you don't see any change in

@casella

  • Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWith3InletOutletArraysWithEvaporatorCondensor (icon has tank with gradient)
  • Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWithTopPorts (icon has tank with gradient)

@christiankral @AHaumer

  • Modelica.Electrical.Machines.BasicMachines.Components.PartialAirGapDC (icon has bar with gradient)
  • Modelica.Electrical.Machines.BasicMachines.Transformers (icon has bars with gradients)
  • Modelica.Electrical.Analog.Interfaces.FourPin (diagram has arrows - they should be solid, no gradients)

etc you can accept it.

For other tools it may be the same, or the older version may lack the gradients (for the ones that should have them).

HansOlsson avatar May 04 '22 09:05 HansOlsson