Hans Mackowiak

Results 413 comments of Hans Mackowiak

When touching the callable, maybe lessen this restriction for `filter_condition_callback`? https://github.com/OpenMage/magento-lts/blob/8e22f8ba87f25576780b485e263a84c62867a757/app/code/core/Mage/Adminhtml/Block/Widget/Grid.php#L572-L574 It stops me to add a column with `filter_condition_callback` via layout updates.

> @Hanmac do you mean `instanceof self` check? Yeah, that extra `instanceof self` check prevents the callback from being defined in a Helper or extra Model

> > @Hanmac do you mean `instanceof self` check? > > Yeah, that extra `instanceof self` check prevents the callback from being defined in a Helper or extra Model It...

Smyfony below 7.3 (mixed asignment/undefined docblock class) https://psalm.dev/r/dbe7e02a86 Symfony more than 7.3 (DeprecatedClass/DeprecatedMethod) https://psalm.dev/r/3915bdd186

Not an "accessibility bypass" like SonarQube thinks

> * not listed here: https://github.com/Seldaek/monolog/blob/main/doc/02-handlers-formatters-processors.md > > * see: https://github.com/Seldaek/monolog/blob/main/src/Monolog/Handler/PsrHandler.php it is listed there, at the bottom of the handler in the "Wrappers / Special Handlers" section: > Can...

> (and possible replace firegento/logger) That's what got me thinking first, i added firegento/logger to another project recently. And after looking into how it works, my first thought was that...

some of them can be fixed with using `ChangeTypeDesc`

@dracontes you might look into the ones that use `Basic.Land` in their Valid, to add `ChangeTypeDesc` @tool4ever, `ChangeTypeDesc` probably needs to be added to descriptiveKeys? So changeText Effects can use...