Hans Mackowiak
Hans Mackowiak
> Was this old branch a step in the right direction? https://github.com/Card-Forge/forge/tree/convokeImproviseDelve Yeah that was the plan (for a part of this issue) You can try to revive it if...
@tool4ever @Northmoc @kevlahnota @tehdiplomat what part of this what we might try to do is the Logic for Hybrid and Phyrexian Costs if the Player would need to choose how...
@Jetz72 I think an easy thing to refactor could be to remove the `CardPredicates.Accessors` and replace `fnGetNetPower` with `Card::getNetPower` and because of these Functional Interfaces, it shouldn't make a difference
Yeah, small steps if able ... like removing the Accessors if able is a good start For the others, some functions that feed into Guava functions can be used for...
@Jetz72 maybe for next cleanup, or **I** try this separate: but this line https://github.com/Card-Forge/forge/blob/master/forge-game/src/main/java/forge/game/card/CardLists.java#L354 could be rewritten to this: ``` public static CardCollection filter(Iterable cardList, Predicate filt) { return StreamSupport.stream(cardList,...
i saw some more uses with `Iterables.any` and `Iterables.all` sprinkled in the code ... it might be a good idea to wrap them in our own functions, so we can...
While checking, i noticed the one and only place where `com.google.common.base.Function` is used: https://github.com/Card-Forge/forge/blob/7ec7a65f33d32e1cd195bc57749e4c573abf0fec/forge-game/src/main/java/forge/game/spellability/AbilityManaPart.java#L661-L670 Probably can be turned into an ArrowFunction? Or into `MagicColor::toLongString` ?
> I think keeping AI support will be the tricky part. For Offering/Emerge, i think once i get the Functionality going, the AI part shouldn't be that much of a...
@tool4ever check out this Issue while touching Offering
@tool4ever you recently touched Offering, https://github.com/Card-Forge/forge/blob/2d20ce07e3ec70b615e9b3ea039ba888c68d3188/forge-gui/src/main/java/forge/player/HumanPlay.java#L520-L540 shouldn't HumanPlay call this Method in CostPayment? https://github.com/Card-Forge/forge/blob/2d20ce07e3ec70b615e9b3ea039ba888c68d3188/forge-game/src/main/java/forge/game/cost/CostPayment.java#L336-L364 Also, isn't this part redundant? https://github.com/Card-Forge/forge/blob/2d20ce07e3ec70b615e9b3ea039ba888c68d3188/forge-gui/src/main/java/forge/player/HumanPlay.java#L606-L615 i might need to clean this up if i want...