Hans Mackowiak

Results 413 comments of Hans Mackowiak

the failed testFormatTimezoneDate is kinda funky, because it looks like it was a timezone/datetime problem. It seems to have been run exactly when the Datetime flipped

I dislike that the new functions still returns false on missing block. (that functions can return false instead of null is something I dislike about old magento core) If they...

I'm with copilot there: `Breaking the method chain reduces readability`

i don't know why `getDefaultTitle` is needed when both `title_prefix` and `title_suffix` exist 🤷‍♂️ but that might be a different issue

Autopay is AI code, so it is affected too

@tehdiplomat looks like we can't bump the testng dependency because of Powermock stuff? Maybe @allentiak can look into it too?

Test crashes because of this: https://github.com/symfony/panther/issues/688 that gets fixed in https://github.com/symfony/panther/pull/678

somehow this PR for php-webdriver is more green: https://github.com/php-webdriver/php-webdriver/pull/1139

@pquerner yeah, there are ways to write my own functions but that doesn't solve the problem that the original `saveAttribute` function causes crashes

in the base `saveAttribute` function: https://github.com/OpenMage/magento-lts/blob/b68185fd345e6ecc3698cc110b932108dc5ac62e/app/code/core/Mage/Eav/Model/Entity/Abstract.php#L1508-L1510 for a static attribute, (without extra backend), then the getTable function returns the base table name Then this part will fail, because the base...