Spells/abilities are incorrectly displayed on the stack

[MorihiroS]

Describe the bug Some spells/abilities have incorrect text when they're displayed in the stack:

• [ ] Assassin's Trophy (It says that a player who cast the spell (not the one who had their permanent broken!!) is looking for the "Basic.Land" card);
• [ ] All is Dust (It says "Sacrifice permanents"");
• [ ] Recross thе Paths (It says "NICKNAMEreveals...", without space before "reveals");
• [ ] Surgical Extraction (It says "CARDNAME (XX) until end of turn. Search...")
• [ ] Activated ability of The One Ring (It says "NICKNAME put a burden counter on The One Ring (XX) for each burden counter on The One Ring. NICKNAME draws zero cards");
• [ ] Last activated ability of Nahiri, the Harbinger (It says "Search your library for an Artifact,Creature card, put it onto the battlefield, then shuffle. gains haste. Return it to your hand at the beginning of the next end step");
• [ ] Crypt Incursion (It says "...You gain 3 life for each card exiled this way. NICKNAME gains 0 life" but it exiles 3 creatures);
• [ ] Wildfire (It says "...deals 4 damage to Creature");
• [ ] Tear Asunder (It says "Exile CARDNAME (XX). Exile.");
• [ ] Sleight of Hand (It says "NICKNAME looks at the top two cards of their library. They put zero of them into their hand and the other on the bottom of their library");
• [ ] Witherbloom Command (It says "Target player mills three cards, then you return a land card from your graveyard to your hand. (Targeting: NICKNAME) NICKNAME2 returns a Land. You Own card from their graveyard to their hand. Target opponent loses 2 life and you gain 2 life. (Targeting: NICKNAME) NICKNAME2 gains 2 life.").

To Reproduce Steps to reproduce the behavior:

1. AI/Player casts Assassin's Trophy/All is Dust/Recross thе Paths/Surgical Extraction/activates The One Ring/etc.
2. See wrong figure

Expected behavior

• Assassin's Trophy (It should say that a player who had their permanent broken may looking for the basic land card.);
• All is Dust (It should say "Sacrifice all colored permanents" or "Each player sacrifices all permanents they control that are one or more colors");
• Recross thе Paths (It should say "NICKNAME reveals...");
• Surgical Extraction (It should say like "NICKNAME choose target CARDNAME (XX) in a graveyard. Search..." );
• Activated ability of The One Ring (NICKNAME put a burden counter on The One Ring, then draw a card for each burden counter on The One Ring);
• Last activated ability of Nahiri, the Harbinger (It should say "Search your library for an artifact or creature card, put it onto the battlefield, then shuffle. It gains haste. Return it to your hand at the beginning of the next end step");
• Crypt Incursion (It should say "......NICKNAME gain 3 life for each card exiled this way");
• Wildfire (It should say "...deals 4 damage to each creature");
• Tear Asunder (It should say "Exile CARDNAME (XX)");
• Sleight of Hand (It should say "NICKNAME looks at the top two cards of their library. They put one of them into their hand and the other on the bottom of their library".);
• Witherbloom Command (It should say "(Targeting: NICKNAME) NICKNAME mills three cards, then NICKNAME2 returns a land card from their graveyard to their hand. (Targeting: NICKNAME) NICKNAME loses 2 life and NICKNAME2 gains 2 life.").

Additional context Similar with #4318

Desktop

• OS: Windows 10
• Java Version: 1.8.0_202-b08
• Forge Version: 1.6.64-SNAPSHOT-07-13

Screenshots

[MorihiroS]

Also problem with activated ability of The One Ring

[MorihiroS]

Also problem with activated ability of Nahiri, the Harbinger, with Crypt Incursion and with Wildfire

[MorihiroS]

@Hanmac, need StackDesc label, GUI label, keep label and assign someone, please

[Hanmac]

some of them can be fixed with using ChangeTypeDesc

[MorihiroS]

Add Tear Asunder, Sleight of Hand and Witherbloom Command

[MorihiroS]

@dracontes, is this issue a part of what you are trying to fix in #6218, #6219 and #6220 ?

[dracontes]

@dracontes, is this issue a part of what you are trying to fix in #6218, #6219 and #6220 ?

I don't think so. The only thing I'm attempting to address in this ball park on those PRs is how additional costs for permanent spells are displayed in different places in-game. From your issue list, I do believe I attempted to tackle Assassin's Trophy, only to realize that, at the time, it was a bit beyond me.

[Hanmac]

@dracontes you might look into the ones that use Basic.Land in their Valid, to add ChangeTypeDesc

@tool4ever, ChangeTypeDesc probably needs to be added to descriptiveKeys? So changeText Effects can use it better? https://github.com/Card-Forge/forge/blob/6d0bf1924248a8188dcec04c2f5382cf7fa45700/forge-game/src/main/java/forge/game/CardTraitBase.java#L62-L63