Vinicius Lourenço
Vinicius Lourenço
We can pass it one by one to see if it's needed, any dependencies used inside `src` should be inside production, any dependencies used just for testing and building should...
Do you have any plans to merge this PR? I want to add deepkit support to my library, but I faced some errors when creating tests because each dependency makes...
I added support GCP into my library [Serverless Adapter](https://serverless-adapter.viniciusl.com.br/), and because it already had support for Apollo Server, now you can deploy Apollo Server to Cloud Functions too. See the...
I think it's a good PR but maybe having some content in each new CLI option will be better than just leaving it empty. The description of each option doesn't...
@Uzlopak Can you rebase? I think there is fixes on CI that this current version is not getting.
I think the slowdown of `getStore` is understandable as the original implementation just calls [JS code](https://github.com/nodejs/node/pull/48528/files#diff-7166454dbde8f899bd0d3a2f20997a5a13a48648eaf129c0088bbd493a604595L364-L369) I think that if we can measure the difference in ms (or us) it...
@aduh95 Here's the benchmark for the rewrite of `fileURLToPath`: > *IMPORTANT*: Those values are not related to this PR, those numbers are only specific to the branch linked above the...
@aduh95 Yeah, my idea was to show you if you really want to do that with the performance benefits from it. To be honest, in this form, without refactoring the...
@GeoffreyBooth Exactly, the way the `fileURLToPath` is used today, simply don't worth exposing the C++ version.
This PR is not about `fileURLToPath`, is about `LegacyMainResolve`. The improvements for `LegacyMainResolve` is about 60~70%. The rewrite of `fileURLToPath` was only because it was needed by `LegacyMainResolve`. Aduh suggested...