node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

docs: test for cli options being in sync between node_options.cc and cli.md

Open Uzlopak opened this issue 1 year ago • 2 comments

This PR has the goal to ensure that we have all cli options documented.

Uzlopak avatar Jan 31 '24 19:01 Uzlopak

@nodejs/documentation @nodejs/testing

Uzlopak avatar Feb 04 '24 15:02 Uzlopak

@mcollina

How can I promote this PR?

Uzlopak avatar Feb 14 '24 22:02 Uzlopak

@H4ad

Any idea how i can get more attention to this PR? :)

Uzlopak avatar Feb 22 '24 09:02 Uzlopak

I think it's a good PR but maybe having some content in each new CLI option will be better than just leaving it empty.

The description of each option doesn't need to be extensive but at least provides some indications about what it does.

You probably can find more information about each flag by looking the PR that adds that flag, for example: https://github.com/nodejs/node/pull/50899

@nodejs/documentation Pinging again just to get more feedback.

H4ad avatar Feb 22 '24 12:02 H4ad

I am happy to add more content, but I wanted to have some feedback before I start writing text which could get rejected.

Uzlopak avatar Feb 22 '24 12:02 Uzlopak

CI: https://ci.nodejs.org/job/node-test-pull-request/57292/

nodejs-github-bot avatar Feb 22 '24 15:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57361/

nodejs-github-bot avatar Feb 23 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57510/

nodejs-github-bot avatar Feb 29 '24 18:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57521/

nodejs-github-bot avatar Mar 01 '24 07:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57522/

nodejs-github-bot avatar Mar 01 '24 10:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57530/

nodejs-github-bot avatar Mar 01 '24 13:03 nodejs-github-bot

@Uzlopak Can you rebase? I think there is fixes on CI that this current version is not getting.

H4ad avatar Mar 01 '24 13:03 H4ad

should i wait till the CI ran through or should I do it proactively now?

done

Uzlopak avatar Mar 01 '24 13:03 Uzlopak

CI: https://ci.nodejs.org/job/node-test-pull-request/57610/

nodejs-github-bot avatar Mar 07 '24 11:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57611/

nodejs-github-bot avatar Mar 07 '24 13:03 nodejs-github-bot

@H4ad

Are the failures related to my PR?

Uzlopak avatar Mar 07 '24 14:03 Uzlopak

Yay, everything green

Uzlopak avatar Mar 07 '24 15:03 Uzlopak

Landed in 999c6b34fb79896ba1457024c4da5c9a64465d3a

nodejs-github-bot avatar Mar 07 '24 18:03 nodejs-github-bot