Vinicius Lourenço

icon indicating a website link https://viniciusl.com.br

icon company Stefanini icon location Sorocaba, SP icon location Software Engineer 🤖 Performance enthusiast :rocket: @nodejs collaborator 💚

Results 95 comments of Vinicius Lourenço

meta: replace build-windows for test-windows

@targos @richardlau Is it okay to remove a part of the test? Based on https://github.com/nodejs/node/pull/50519#issuecomment-1791806986, I don't think that test will run on Github CI, that test doesn't even run...

meta: replace build-windows for test-windows

@targos Bash is already installed: https://github.com/nodejs/node/actions/runs/6751686476/job/18356112178?pr=50519#step:4:50 As I mentioned on https://github.com/nodejs/node/pull/50519#issuecomment-1791806986, I don't think the test will be able to run when `Git Bash` is installed or when WSL is...

meta: replace build-windows for test-windows

Closing this one since I have no clue on how I should properly fix those issues on Win :/

perf: avoid regexp for generate alphabetic name fn

Which value represents this PR?

perf: avoid regexp for generate alphabetic name fn

I know for sure this will be faster but maybe the impact on the benchmark is not much relevant, so is up to you to merge. At least when I...