Vinicius Lourenço

Sorry for taking so long to fix the issues, I was taking a break from OSS. I fixed all the changes on the snapshot tests, since we introduced a new...

@joyeecheung The current CI is failing because the `trace` is emitting every string without escaping, so something like this: ```js console.time('C:\\wddd'); setTimeout(() => console.timeEnd('C:\\wddd'), 200); ``` Will emit an invalid...

I added escaping for `\\` and also a test to ensure it's working for `console.time`. I also tried to fix all issues on Windows, so now it _should_ pass all...

I got some errors from CI, one of them is: ``` not ok 2208 parallel/test-module-print-timing 18:02:18 --- 18:02:18 duration_ms: 340.76000 18:02:18 severity: fail 18:02:18 exitcode: 1 18:02:18 stack: |- 18:02:18...

The issue was probably introduced by this change introduced by https://github.com/nodejs/node/pull/51021: https://github.com/nodejs/node/blob/f75dc4193e3faa66d0a827400c150cedf2412700/lib/internal/fs/utils.js#L200-L205 The main PR https://github.com/nodejs/node/pull/50976 didn't include these changes.

@gm-al Basically waiting for a PR, feel free to work on it if you want :) You can ping me when you had something to review

@dario-piotrowicz Thanks for the reminder, closing since this is no longer applicable.

@lemire He will have the ability to edit once he becomes a nodejs collaborator (probably next week)

Building locally, I got this: ``` C:\Users\vinic\Desktop\Projects\node\src\node_file.cc(3036,15): error C2664: 'void node::Environment::ThrowUVException(int,const char *,const char *,const char *,const char *)': cannot convert argument 4 from 'const std::filesystem::path::value_type *' to 'const char...

@targos This test is probably failing because of this error: ``` C:\Users\vinic\Desktop\Projects\node>"C:\Program Files\Git\usr\bin\bash.exe" ls /usr/bin/ls: /usr/bin/ls: cannot execute binary file ``` But I didn't find a way to get that...