Mark Stacey
Mark Stacey
When creating a bundle with Browserify using `.require`/`--require` in debug mode, invalid source maps are sometimes generated. The `sources` property in the resulting source map will include the bare package...
Validation has been added to the build script when the "prod" target is selected. We now ensure that all expected environment variables are set, and that no extra environment variables...
We have a set of redundant streams between `contentscript.js` and the provider in-place today to support websites and extensions that implemented their own providers rather than using our injected `inpage.js`...
Currently the build script doesn't validate that expected environment variables are set for production builds. This is because the build script doesn't know the difference between a real production build...
Merge the network controller in this repository with the extension network controller. General guidelines: * Write comprehensive unit tests for both current network controllers * This is the first step...
We have recently switched to Dependabot, which does not support Yarn v3. We still want to automate the bumping of dependencies to save us time, especially to address security advisories,...
Many controllers initialize with the `chainId` or `networkType` set to `1` or `MAINNET` respectively, because that is the default network. The configuration gets updated whenever the network state changes, but...
We currently store the chain ID in different formats throughout MetaMask products and libraries. It can be a number, a decimal string,a `0x`-prefixed hexadecimal string, or a non-prefixed hexadecimal string....
The TypeScript flag `exactOptionalPropertyTypes` has been enabled, which causes TypeScript to distinguish between object properties that don't exist and properties that are set to `undefined`. This improves type safety for...
All `private` fields and methods have been converted to ECMA #private fields. This ensures that are actually private at runtime, rather than access just being disallowed by the TypeScript compiler.