Mark Stacey
Mark Stacey
>One difference with this method is that we don't use shouldInjectProvider which does various checks for Doctype, host, etc. Not sure if we'll find that perfectly acceptable. We can move...
>I add a bit of delay in resetStreamAndListeners method by adding a timeout, stream re-connection does not happen. To follow up from the call we just had discussing this: I...
I was able to reproduce this bug. It appears to fail intermittently. This us to a bug with Infura (apparently related to load balancing) - they have a fix in...
~This depends upon #15464, #15447, and #15493~ This is ready for review
Merging this will close #15379
@dependabot rebase
It looks like that library still accepts the mnemonic as a string, and it still returns the mnemonic as a string (e.g. [here](https://github.com/paulmillr/scure-bip39/blob/main/src/index.ts#L79) and [here](https://github.com/paulmillr/scure-bip39/blob/main/src/index.ts#L99)). Using this library would mean...
We need a deprecation plan before we can merge this, including messaging to any existing users
`requesterAddress` has always been `null`. See [the original PR here](https://github.com/MetaMask/metamask-extension/pull/2479). At one point it showed the Ethereum logo as a default, that must have broken at some point. @danjm might...
Those two ideas sound promising. I don't envision the new dist target as helping with that goal, because neither the existing dist target nor the new prod target are directly...