Gold856
Gold856
Rebased on main to account for #6296.
```diff diff --git a/wpimath/CMakeLists.txt b/wpimath/CMakeLists.txt index a22ffc0b8..b341313a2 100644 --- a/wpimath/CMakeLists.txt +++ b/wpimath/CMakeLists.txt @@ -151,9 +151,7 @@ endif() file(GLOB_RECURSE wpimath_native_src src/main/native/cpp/*.cpp) list(REMOVE_ITEM wpimath_native_src ${wpimath_jni_src}) -set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS FALSE) add_library(wpimath ${wpimath_native_src} ${WPIMATH_PROTO_SRCS}) -set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS TRUE)...
I managed to fix the build by explicitly exporting the missing symbols. Create an exports.def file (I placed it under wpimath/src/main/native). Add this to it: ``` EXPORTS ??$CreateMaybeMessage@VProtobufSimpleMotorFeedforward@proto@wpi@@$$V@Arena@protobuf@google@@CAPEAVProtobufSimpleMotorFeedforward@proto@wpi@@PEAV012@@Z ??$CreateMaybeMessage@VProtobufTranslation2d@proto@wpi@@$$V@Arena@protobuf@google@@CAPEAVProtobufTranslation2d@proto@wpi@@PEAV012@@Z ?Clear@ProtobufTranslation2d@proto@wpi@@UEAAXXZ...
Per #6772, you'll need to include `` and switch out every instance of `google::protobuf::Arena::CreateMessage` with `wpi::CreateMessage`.
Have we decided on whether or not we want to keep the control commands? If we are going to deprecate them, we should do it this year so we won't...
Since we're getting close to kickoff, can this PR be rebased and changed to deprecate the control subsystems and remove the subclassing examples? Best to deprecate sooner rather than later.
If we remove control commands, I'm concerned that less experienced teams will struggle to create commands that use PIDControllers or motion profiles. It may not reduce boilerplate by that much,...
I don't like how it changes PowerDistribution to use NTSendable instead of Sendable. Logging Sendables with DataLog is something that would be desirable, and the more classes that use NTSendable,...
Since [JDK 18](https://bugs.openjdk.org/browse/JDK-8275351), doclint can be supressed with the usual `SuppressWarnings`, which isn't helpful for us because we're on JDK 17. And updating to JDK 21 (the next LTS release)...
For posterity, #6119 removed about 3000 warnings.