Guillaume Giudicelli comments

Results 719 comments of


                                            Guillaume Giudicelli

Option to bypass mesh generation using RGMB mesh generators

whereever generateMesh() is being called for each MG could do that check? This special case (using MGs to not generate a mesh) was never meant to be added so I...

Option to bypass mesh generation using RGMB mesh generators

Yes I think this change could catch most of the problems Either that or have a similar change that detects an empty mesh I think the ElementGenerator use case you...

Option to bypass mesh generation using RGMB mesh generators

I doubt it will work as is. The minimal amount of work to be able to avoid this case of 'rgmb generated an invalid mesh that got passed to another...

Add an alias for std::vector<VariableName>

VariableNameVector would be fine for me My only concern with `CoupledVariables` is that it points to the Coupleable interface, but what if it s used outside that context? Maybe we...

Remove recover testing from all Steady tests

I think so if we are trying to recover in between nonlinear solves for example. I don't know that we can do that

Rename PatchMeshGenerator

The rename is done. A good next step would be to move it to the test objects and use the MOOSE test objects in BISON

unrecognized variables when using output file to initialize variables

This is a problem coming from multi-system + exodus restart from my limited investigation

To enable restart a crystal plasticity simulation from checkpoint

Assigning you for the merge @jiangwen84

To enable restart a crystal plasticity simulation from checkpoint

@sapitts @jiangwen84 @loganharbour can we get an update on this please? Just making sure the delay on the merge is still intended

Values not substituted in multiple input file context

If there are equidistant points, the result of the transfer is indeed ill-defined. So anything goes, a round-off error in one or the other direction can change the output of...