moose icon indicating copy to clipboard operation
moose copied to clipboard

Remove recover testing from all Steady tests

Open GiudGiud opened this issue 2 years ago • 2 comments

Reason

The way these tests go is:

  • regular solve
  • recovers after it, exits immediately after setup with
executioners/executioner.test_steady_adapt: 
executioners/executioner.test_steady_adapt: 
executioners/executioner.test_steady_adapt: Cannot recover steady solves!
executioners/executioner.test_steady_adapt: Exiting...
executioners/executioner.test_steady_adapt: 

there's some testing going on in that it shows we can initialize a new simulation. But it s really not a complete picture like running a transient recover.

Design

Find every test running a steady solve, add recover = false to the test spec OR Do that but with a python script OR Modify the test harness to detect Steady and skip by itself (best solution)

Impact

Less testing, less resource use, lower turnaround on civet

GiudGiud avatar Jan 06 '24 14:01 GiudGiud

Should recovery be allowed for Steady in the code?

joshuahansel avatar Jan 16 '24 17:01 joshuahansel

I think so if we are trying to recover in between nonlinear solves for example.

I don't know that we can do that

GiudGiud avatar Jan 16 '24 21:01 GiudGiud