Guillaume Giudicelli

A few options here: - Saline gets modified to remove the warning - #pragma GCC diagnostic ignored "-Woverloaded-virtual" get added to Saline - we pass additional flags to undo the...

That's great news I just rebased and updated the submodule, see where we stand

We are still hitting the errors. I just squashed unnecessary commits and tried adding another flag to build Saline. This may not be quite what we want, I ll have...

something like : ` function(other arguments..... , Real /*pressure*/)` will do here It will remove the unused variable warning, while keeping the argument / same function signature

ok we cant do what I did [here](https://github.com/idaholab/moose/pull/22725/commits/cc8074fa3c7693e2449563a8473909355c56e43a), it propagates to the whole repo Daniel's fix wouldnt be too bad to do on the Saline side

I agree let's figure this make command out to enable the flag very locally to Saline In the meantime a few things to consider: - line coverage is very low....

There is no saline target though in the Makefile. I think all the code is compiled under the same target. @permcody any idea how to move forward here

Just added a unit test and rebased due to a conflict with the submodule list (wasp just got added) It seems there are two comments from Daniel left. If my...

Test suite is failing because documentation is missing. I ll catch the formatting things in another commit but someone more qualified should write the actual SalineFluidProperties documentation (in doc/content/source/fluidproperties)

Testing already includes Saline and is now green (failure is Griffin, unrelated) @dschwen if you could please review, I have too many commits here