Geoffrey Booth

Results 579 comments of Geoffrey Booth
trafficstars

There can be a meeting at that time, too, but I can’t attend that one. This one is ad hoc because @DanielRosenwasser asked to discuss the TypeScript work, and I...

@nodejs/loaders plus the participants of https://github.com/nodejs/loaders/issues/103: @cspotcode @giltayar @arcanis @bumblehead @bizob2828 plus participants of https://github.com/nodejs/node/pull/53332: @VoltrexKeyva @Flarna @alan-agius4

As paths are URLs in ESM, "dir" is perhaps not the best name. But aside from naming, yes, this would be a good method to expose. In https://github.com/nodejs/node/issues/33460#issuecomment-630968792 I had...

> ```js > module.getPackageDir(specifier, baseDir) > ``` My preference would be to call it `getPackageRoot`, but otherwise it's fine. In general most docs these days prefer “folder” to “directory,” and...

I’ve proposed this in the past, such as in https://github.com/nodejs/node/issues/49148#issuecomment-1747102503 and https://github.com/orgs/nodejs/discussions/44975#discussioncomment-3868855. The short version is that I think we need a config file, such as `node.config.json` or possibly a...

It's important that the format be easily editable by other tools, such as those registering hooks. Anything other than comment-less JSON means that those tools need a dependency, unless we...

Whatever format we read needs to be parseable in C++. We added simdjson to be able to parse JSON in C++, so that’s an option. The addition of `--env-file` gave...

I was thinking that whatever config file we choose would be loaded automatically as a semver-major change, and a flag could specify it for older Node versions. A flag might...

> How could this feature be used successfully across different package.json scripts? I think we would ship a flag, like `--config`, in addition to whatever other ways there are to...

> I wonder if we should just support preloaded JavaScript files specified in package.json JavaScript files wouldn't be editable by other tools, for example to register hooks.