Geoffrey Booth

Results 597 comments of Geoffrey Booth
trafficstars

> Issue 1: Reverting the change in the release branch to unbreak the folks this change broke. This should be our immediate first action. > > Issue 2: What is...

> Let's land the revert now, and then let's open a "revert revert" PR that can also land immediately with dont-land- labels. I'm okay with this if the latter PR...

> Personally, I would opt for a solution based on https://github.com/nodejs/node/pull/53200#issuecomment-2140162671. But #53200 needs some work after the last discussions and it would be good to be able to do...

> let’s just fast-track the revert and the revert-revert, no one is going to block it. As long as it can’t be blocked, that’s fine, I’m happy to do whatever...

So just to build on my suggested way forward in https://github.com/nodejs/TSC/issues/1566#issuecomment-2142313742, let’s do whatever reverts and revert reverts or whatever the proper procedure is right after the next TSC meeting;...

If https://github.com/nodejs/node/pull/53200 including `context.workerData`/`context.threadId` (what I proposed in https://github.com/nodejs/TSC/issues/1566#issuecomment-2143613293) is ready by the 22.3.0 cutoff, and no one blocks it, then we don’t need to do a revert at all....

> The solution @GeoffreyBooth is proposing is to "use child processes" if isolation is required. I don't think this is quite accurate. If each hook has access to each thread's...

> Sorry I misunderstood the proposal. This can work. Okay. I’ve approved the revert, since based on https://github.com/nodejs/node/issues/53195#issuecomment-2143726849 it seems like my suggestion of `context.workerData` probably can’t be ready in...

> We have good progress happening today here already Based on the collab summit and recent discussions, I think we might have consensus that we want to revise https://nodejs.org/en/download to...

cc @nodejs/loaders plus the participants of https://github.com/nodejs/loaders/issues/103: @cspotcode @giltayar @arcanis @bumblehead @bizob2828 plus participants of https://github.com/nodejs/node/pull/53332: @VoltrexKeyva @Flarna @alan-agius4