Geoffrey Booth

Results 538 comments of Geoffrey Booth

@mhart Thanks for your help. I took another look at that `Makefile`. The `docker-compose.yaml` that I got to work looks like this: ```yaml version: '3' services: aws-sam-local: image: cnadiminti/aws-sam-local command:...

I don't think so. This is what I used: https://github.com/cnadiminti/docker-aws-sam-local/pull/2/files

I think it’s time to at least update the docs to add a note next to the `async_hooks` API saying that at some point we intend to make it an...

Sure, we can say that it's becoming internal without mentioning `--expose-internals`. Or we could leave out the detail about it continuing to exist internally and just say that we intend...

> There needs to be a discussion among APMs though first to validate that our needs are solved, and if not, to identify what additions are needed to satisfy those...

`banner` takes an object: ```ts const buildOptions: BuildOptions = { ...common, format: "esm", target: "esnext", platform: "node", banner: { js: "import { createRequire } from 'module'; const require = createRequire(import.meta.url);",...

The purpose of `banner` is not to polyfill missing initialization code. This bug should still be fixed.

I don’t know what to do with this. I worry that it could break some people, like bundlers that expect the current output, and I don’t really see why the...

> coffee being able to work directly based on "type": "module" The `coffee` command itself relies on the Node `vm` module which still lacks ESM support and no one is...

@arcanis I’d love to land this, if you have time to get it passing CI.