coffeescript icon indicating copy to clipboard operation
coffeescript copied to clipboard

Move sourceMappingURL to last line

Open mohd-akram opened this issue 6 years ago • 3 comments

This is more in line with the spec which says "the generated code may include a line at the end of the source, with the following form: //# sourceMappingURL=<url>" and "there exists a //# sourceURL comment in the generated code". It also looks better since the sourceMappingURL is very long. Also, add a trailing newline. This was motivated by mishoo/UglifyJS2#3441.

mohd-akram avatar Oct 10 '19 01:10 mohd-akram

I guess? Would this be a breaking change for anyone?

GeoffreyBooth avatar Oct 10 '19 16:10 GeoffreyBooth

Going on a limb here - it's been a few years - but wasn't there some I.E. bug if the last line contained some specific characters that could pose an issue? Maybe we don't need to care, to be fair...

vendethiel avatar Oct 10 '19 17:10 vendethiel

Is this good to merge?

mohd-akram avatar Sep 13 '22 10:09 mohd-akram

Any update on this?

mohd-akram avatar Jun 17 '23 09:06 mohd-akram

I don’t know what to do with this. I worry that it could break some people, like bundlers that expect the current output, and I don’t really see why the change is needed.

GeoffreyBooth avatar Jun 19 '23 03:06 GeoffreyBooth