Gary Jones

Results 267 comments of Gary Jones

Needs updating to fix a merge conflict, but I think this is worthwhile.

I guess removing it would be sufficient.

The cache should have an interface and be an object too - storing and retrieving, so that the implementation (the fact it's stored in transients, but it could equally have...

I think we could expand this and target the outermost div (currently `class="gist"`) to add in a _feature_ / _no-feature_ class for highlighting, shown meta, shown line-numbers etc.

I'm thinking of feature classes alone the lines of `gist-has-meta`, `gist-has-line-number`, `gist-has-no-lines-highlighted` etc. We should be able to determine which features are used, and then adapt the classes in ``...

What you've now got is better. This will add a class to the line, rather than the overall table or div that indicates no highlighting. Is that what you're after?...

https://github.com/Automattic/amp-wp#handling-media Looks like there might be some custom embed handler we could use, that would allow at least something to be displayed, instead of it getting stripped out completely.

There is now an [`amp-gist` component](https://www.ampproject.org/docs/reference/components/amp-gist).

Me personally, no, but someone asked for it :-) Think of a CPT that has custom fields for splitting up different parts of the content - perhaps an introduction, the...

This gist processor may even be better being pulled out into a new class?