Gary Jones
Gary Jones
Another use case: I tried "Third Thursday next month", and "Third Thursday of last month" and both times it selected the third Thursday of the current month.
That `:focus` is far to generic. It's been bugging me (but I'd not found a definitive breakage like you have).
@cgrymala Do you know if this is still an issue?
> WPCS is primarily meant to be run on your own code, not on the code of others which you don't maintain. This is exactly the use case I've described....
> Should it also examine JS in inline HTML/generated HTML in PHP files ? Yes, definitely.
@gmazzap pointed out that [this DocBlock](https://github.com/Automattic/VIP-Coding-Standards/blob/4d0612461232b313d06321f1501c3989bd6aecf9/WordPressVIPMinimum/Sniffs/Performance/CacheValueOverrideSniff.php#L13-L23) for CacheValueOverride is incorrect (copy-pasta). It's not been substantially changed for 4 years!
When running the fixer again on an already fixed line: ```php $this->current_provider = new $this->providers->{$this->current_provider_slug}['provider'](); ``` ...then the mid-line "fix" gets added again, leading to: ```php $this->current_provider = new $this->providers->(){$this->current_provider_slug}['provider']();...
As a workaround, changing it to: ```php $class = $this->providers->{$this->current_provider_slug}['provider']; $this->current_provider = new $class; ``` results in it being correctly fixed to: ```php $class = $this->providers->{$this->current_provider_slug}['provider']; $this->current_provider = new $class();...
VIPCS contains two standards - `WordPressVIPMinimum`, meant for code that lives on WordPress.com VIP, and `WordPress-VIP-Go`, meant for code that lives on the VIP Go platform. Once customers have migrated...
I have come across issues with `\` scoped items, but under a slightly different context (and I can't find the relevant issue).