Gary Jones

Results 276 comments of Gary Jones

> words should be separated by an underscore. Please make the check for use of underscores versus PascalCase be optionally disable-able - folks may want to go against that for...

#364 is likely the biggest missing piece from this sniff.

Per the [bug report template](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/develop/.github/ISSUE_TEMPLATE/bug_report.md), please provide the minimal snippet, error code, etc. This helps us to agree on exactly what the problem is.

> Should it also examine JS in inline HTML/generated HTML in PHP files ? Yes, definitely.

Also, as per https://github.com/Dealerdirect/phpcodesniffer-composer-installer/pull/132/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34 the dealerdirect plugin has had PHP 8 support since 0.7.0 (see the [releases](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)).

@paulschreiber (Aside: Your first "Output:" block indicates that the file gave a warning, but my testing, and your description suggests this isn't the case - I'm assuming this is copy-pasta.)...

Thanks - we'll bear this in mind when we look into this more. Related: https://github.com/Automattic/vip-go-ci/issues/64

Not on this item specifically, but we've got a task underway that should allow someone time to focus on making improvements like this across all of VIPCS.