Gary Jones

PHPUnit\Framework\MockObject\MockBuilder::onlyMethods is not polyfilled

1

As per https://github.com/sebastianbergmann/phpunit/pull/3687, the `PHPUnit\Framework\MockObject\MockBuilder::setMethods()` method was deprecated (soft in PHPUnit 8, hard in PHPUnit 9) and scheduled for removal in PHPUnit 10. It was being replaced by `onlyMethods()` and...

Fixer for missing parentheses adds them to the wrong place in one case

7

## Bug Description The fixer for the missing parentheses sniff adds the parentheses to the wrong place for a particular statement. ## Minimal Code Snippet ```php $this->current_provider = new $this->providers->{$this->current_provider_slug}['provider'];...

Add IDE exports

2

Worth adding a directory of exports from IDEs, with instructions on how to import them, so that the code formatted by IDEs at least start off as close to WP...

A11y: Restrict title attribute to iframe element

7

I'd like to consider what sniffs could be written that address programatically testable accessibility concerns. The first is to check for the use of the `title` attribute, and flag it...

Allow different text-domains per subdirectory

4

## Is your feature request related to a problem? In a site-level directory, there may be different directories of custom code - plugins and theme(s). It's not possible to set...

Recommend the_title_attribute() instead of esc_attr( get_the_title() )

3

## Is your feature request related to a problem? `the_title_attribute()` automatically strips tags from `get_the_title()` and escapes the echoed or returned value ready for it to be added to an...

## What problem would the enhancement address for VIP? When template partials are `require`'d from within a class, then the partial may use `$this->` to insert display a value. At...

## What problem would the enhancement address for VIP? Some developers are not aware that `esc_url()` supports more than just the `http` and `https` protocols. The default list also includes...

## What problem would the enhancement address for VIP? `esc_xml()` is being [introduced in WP 5.5](https://make.wordpress.org/core/2020/07/21/new-esc_xml-function-in-wordpress-5-5/). It would be great if WordPressVIPMinimum.Security.ProperEscapingFunction sniff could recognise when an escaping function is...

Add sniff to delete_option() + add_option

4

## What problem would the enhancement address for VIP? As explained at https://github.com/woocommerce/woocommerce/pull/27696 there is a race condition when `delete_option('foo')` is followed by `add_option('foo', '...')`. ## Describe the solution you'd...