(Jip) Willem Wijnia

Results 464 comments of (Jip) Willem Wijnia

My first impression is that it all seems fine. Thank you for writing the pull request. We'll take this with the 4th developers iteration. I'll give it a test once...

@clyfordv is this ready for testing?

Let's first try to merge the current feature set before we extend on it

Would you mind if I make some edits / add annotations as I see fit?

Would you mind introducing an MIT license to the top of the code? As an example: - https://github.com/FAForever/fa/blob/deploy/fafdevelop/lua/sim/NavGenerator.lua#L1-L21 But then with a name of your choosing, of course

@clyfordv how would this work with the new tactical missile trajectory?

@clyfordv I'd love to include this; what is the status quo at the moment?

the missile changes are settled in if you ask me. At best we may increase their fire rate and reduce the damage at this point.

The minimum range increase was discussed with and accepted by the balance team. You're free to adjust some of the trajectories to make them work better up close 😃 ....

Is this the final behavior*? Once we go to the release branch there's no going back