Gareth Jones

Results 733 comments of Gareth Jones

That's a fair take - Personally I think that the nature of rules like this imply that they're about letting you know when there isn't a difference (to apply reductio...

@robvanderleek I don't think that PR needs landing for OIDC since you can [specify a specific version of `semantic-release`](https://github.com/cycjimmy/semantic-release-action?tab=readme-ov-file#semantic_version) - there could be other changes, but I think what needs...

I think given the rule doc says "which can indicate an unfinished test." this is technically a bug, but I think a fair counter argument would be that when the...

Could you explain this change a bit more, ideally with some linkage to official documentation? My expectation is that GH already uses caching when appropriate for docker images, and doesn't...

I understand it aims to speed up CI, but it's not clear to me if this is official, stable, trust worthy, etc which is why ideally I'd like some docs...

You still need to call `os.Exit` manually in `TestMain` if you want a non-zero exit code, such as because pre-test setup or post-test cleanup failed like in my example. The...

Also just noting that cleanup runs after the (sub)tests have completed, not when `TestMain` returns i.e. by the time `m.Run` is finished, cleanups have been run - so the use...

I think you should be able to reasonably improve the rule based on: - is `defer` used in `TestMain`? - is the return of `m.Run` assigned to a variable? If...

It looks like that is a feature of the `defineConfig` helper, not actually ESLint itself - personally I think I'd prefer to stick with what we have for now since...