Gareth Jones

Results 733 comments of Gareth Jones

Yeah that is probably the way to go given how much rebasing this has needed anytime something else is merged in, and then we can work on building on this....

@eoinkelly we marked this as ready for dev _because_ we got consensus - I believe overall it was more that there weren't any strong disagreements or downsides not to rather...

I've created https://github.com/ackama/aws_ec2_environment/pull/9 to showcase this in action

glob v7.2.3 is not vulnerable - only the v10 and v11 major version lines are impacted

@diegomarcuz none of the versions in your screenshot are vulnerable

Correct, only those with the red highlight are vulnerable. You can also use tools like [`osv-scanner`](https://github.com/google/osv-scanner) to verify this

@waynzh would it be possible to get a review or even just a yay/nay on if you're open to this?

I'm personally not fussed so if you're happy having double the amount of configs I'm fine to do it that way too - I just figured the env variable was...

> For the IDE DX issue, you can address it by configuring the IDE-ESLint integration like this: That only works for VSCode > I'm not a big fan of controlling...

@FloEdelmann @waynzh @ota-meshi I've updated the implementation to generate dedicated configs instead of using an env variable